-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add product/file version in Windows executables #4811
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Oct 6, 2023
yurishkuro
reviewed
Oct 6, 2023
yurishkuro
reviewed
Oct 6, 2023
yurishkuro
reviewed
Oct 6, 2023
yurishkuro
reviewed
Oct 6, 2023
yurishkuro
reviewed
Oct 6, 2023
yurishkuro
reviewed
Oct 7, 2023
yurishkuro
reviewed
Oct 7, 2023
ResamVi
force-pushed
the
main
branch
4 times, most recently
from
October 7, 2023 17:14
055f3d1
to
4bf3de4
Compare
yurishkuro
reviewed
Oct 7, 2023
yurishkuro
reviewed
Oct 7, 2023
yurishkuro
reviewed
Oct 7, 2023
yurishkuro
reviewed
Oct 7, 2023
Signed-off-by: Julien Midedji <[email protected]>
4 tasks
yurishkuro
approved these changes
Oct 8, 2023
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
Thanks! 🎉 |
yurishkuro
added
the
changelog:new-feature
Change that should be called out as new feature in CHANGELOG
label
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This resolves #3414
Description of the changes
Add to the windows build step in
Makefile
to create aresource.syso
using goversioninfo. The version is extracted from the latest git tag.go build
will embed this information in the final executable(Forgive the German in this screenshot)
How was this change tested?
make build-binaries-windows
cmd/agent/agent-windows-amd64
).exe
to the file name for the changes to be seen:agent-windows-amd64.exe
Ran other targets (
make build-binaries-linux
) to see if it broke other targets. Looked fine so far.Notes
There is the hassle of creating a
.syso
file that must be in the same directory as the main.go file so there's a lot of copying to eachcmd/*
.I tried to keep it centralized to a
prepare-winres
Makefile target and the files are cleaned up afterwards.Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test