Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test[es]: Force batch size 1 in test #4865

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Oct 19, 2023

Which problem is this PR solving?

The test is still failing: https://github.com/jaegertracing/jaeger/actions/runs/6577136964/job/17868105418#step:7:461

From the logs we can see that the new client is started to be used (HEAD requests with new password), but then a bulk request with password1 comes in and breaks the test.

Description of the changes

  • Set BulkSize to -1, which according to the driver docs disables bulk processing.

How was this change tested?

  • Local test is successful, but the issue is difficult to reproduce

@yurishkuro yurishkuro requested a review from a team as a code owner October 19, 2023 16:37
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro changed the title test: Force batch size 1 in test test[es]: Force batch size 1 in test Oct 19, 2023
@yurishkuro yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

see 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit 4e4d2bc into jaegertracing:main Oct 19, 2023
33 of 34 checks passed
@yurishkuro yurishkuro deleted the fix-4743 branch October 19, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test] Flaky test TestPasswordFromFile in plugin/storage/es/factory_test.go
1 participant