Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp: Support primary and archive storage #4873

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Oct 21, 2023

Which problem is this PR solving?

Description of the changes

  • Introduce trace_storage_archive argument to extension/jaegerquery
    • This is temporary, need to design a better shape for the config
  • Implement initialization of archive storage. Tested manually.
  • Changed memstore to implement archive storage (maybe not a good idea in retrospect)
  • Change how no-config condition is detected as the previous changes worked for all-in-one but broke with-config mode
    • Need to start adding some basic integration tests
    • There is a better way than using default configs for all in one - override --config flag with yaml: .... string an provide configuration as a file (embed the file into the binary)
  • Some refactoring of querysvc/app to be able to reuse querysvc.QueryOptions in v2 config

How was this change tested?

  • Run all-in-one
  • Run with config
  • Run with custom UI config to enable Archive button (it should really be dynamically determined by backend capability)

@yurishkuro yurishkuro requested a review from a team as a code owner October 21, 2023 01:01
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
cmd/query/app/flags.go 100.00% <100.00%> (ø)
cmd/query/app/static_handler.go 97.77% <100.00%> (+0.01%) ⬆️
plugin/storage/memory/factory.go 76.31% <0.00%> (-8.98%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro added the changelog:exprimental Change to an experimental part of the code label Oct 21, 2023
@yurishkuro yurishkuro merged commit 244b4be into jaegertracing:main Oct 21, 2023
32 of 34 checks passed
@yurishkuro yurishkuro deleted the jv2 branch October 21, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:exprimental Change to an experimental part of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant