-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release 1.51.0 #4914
Prepare release 1.51.0 #4914
Conversation
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
| 1.53.0 | @pavolloffay | 3 January 2023 | | ||
| 1.53.0 | @joe-elliott | 7 February 2023 | | ||
| 1.54.0 | @albertteoh | 6 March 2023 | | ||
| 1.53.0 | @pavolloffay | 3 January 2024 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Caught us napping 😅
|
||
#### 👷 CI Improvements: | ||
|
||
* Ci: split the install-tools into test/build groups ([@MeenuyD](https://github.com/MeenuyD) in [#4878](https://github.com/jaegertracing/jaeger/pull/4878)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Ci:
prefixes seem a little superfluous, and similarly for other sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, although not unusual in other projects. Now that we switched to using labels we should pay closer attention to PR titles to be exactly what we want to show up in the changelog.
next release (yyyy-mm-dd) | ||
------------------- | ||
|
||
### Backend Changes | ||
|
||
#### ⛔ Breaking Changes | ||
run `make changelog` to generate content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the motivation for adding this? It's already documented in RELEASE.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was distracting / confusing having empty sections especially after copying the template, and there were many sections that are no longer necessary.
No description provided.