Clarify release docs slightly #5809
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Kowall <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5809 +/- ##
==========================================
+ Coverage 96.65% 96.66% +0.01%
==========================================
Files 342 342
Lines 16521 16521
==========================================
+ Hits 15968 15970 +2
+ Misses 363 362 -1
+ Partials 190 189 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
added
the
changelog:skip
yurishkuro
reviewed
Aug 6, 2024
| @@ -5,7 +5,8 @@ | |||
| * A curated list of notable changes and links to PRs. Do not simply dump git log, select the changes that affect the users. | |||
| To obtain the list of all changes run `make changelog` or use `scripts/release-notes.py`. | |||
| * The section can be split into sub-section if necessary, e.g. UI Changes, Backend Changes, Bug Fixes, etc. | |||
| * If the jaeger-ui submodule has changes cut a new release and also upgrade the submodule versions then commit, for example: | |||
| * If the jaeger-ui submodule has changes cut a new release | |||
There was a problem hiding this comment.
We agreed that UI release numbers will now match the backend release numbers, so "if ui has changes" is misleading, we should make it unconditional Step 1: release UI.
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 13, 2024
Just improving the docs a bit to make sure the release manager does the Jaeger UI before the rest of the directions. Signed-off-by: Jonah Kowall <[email protected]> Signed-off-by: Jared Tan <[email protected]>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 14, 2024
Just improving the docs a bit to make sure the release manager does the Jaeger UI before the rest of the directions. Signed-off-by: Jonah Kowall <[email protected]> Signed-off-by: Jared Tan <[email protected]>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 28, 2024
Just improving the docs a bit to make sure the release manager does the Jaeger UI before the rest of the directions. Signed-off-by: Jonah Kowall <[email protected]> Signed-off-by: Jared Tan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just improving the docs a bit to make sure the release manager does the Jaeger UI before the rest of the directions.