Use GRPC interceptors instead of explicit context wrappers #6133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6133 +/- ##
==========================================
+ Coverage 96.41% 96.43% +0.01%
==========================================
Files 353 353
Lines 20135 20128 -7
==========================================
- Hits 19414 19410 -4
+ Misses 535 532 -3
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Oct 28, 2024
Signed-off-by: chahatsagarmain <[email protected]>
yurishkuro
reviewed
Oct 29, 2024
| @@ -117,7 +82,7 @@ func (c *GRPCClient) ArchiveSpanWriter() spanstore.Writer { | |||
|
|
|||
| // GetTrace takes a traceID and returns a Trace associated with that traceID | |||
| func (c *GRPCClient) GetTrace(ctx context.Context, traceID model.TraceID) (*model.Trace, error) { | |||
| stream, err := c.readerClient.GetTrace(upgradeContext(ctx), &storage_v1.GetTraceRequest{ | |||
There was a problem hiding this comment.
where is the code that attaches interceptors to the client that would do these upgrades instead?
There was a problem hiding this comment.
Interceptors are being attached to shared client in /plugin/storage/grpc/factory.go
jaeger/plugin/storage/grpc/factory.go
Line 162 in 6a520a5
yurishkuro
approved these changes
Oct 29, 2024
yurishkuro
changed the title
|
Thanks! |
yurishkuro
added a commit
to yurishkuro/jaeger
that referenced
this pull request
Nov 2, 2024
…aegertracing#6133)" This reverts commit 0af8d35.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test