Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test to reproduce data race when reloading TLS config #6213

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chahatsagarmain
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Added unit to test to check for data race

How was this change tested?

Checklist

Signed-off-by: chahatsagarmain <[email protected]>
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.93%. Comparing base (2b7cf3a) to head (3d175ce).

❗ There is a different number of reports uploaded between BASE (2b7cf3a) and HEAD (3d175ce). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (2b7cf3a) HEAD (3d175ce)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6213       +/-   ##
===========================================
- Coverage   96.50%   48.93%   -47.58%     
===========================================
  Files         354      178      -176     
  Lines       20127    10774     -9353     
===========================================
- Hits        19424     5272    -14152     
- Misses        520     5060     +4540     
- Partials      183      442      +259     
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.60% <ø> (+<0.01%) ⬆️
elasticsearch-7.x-v1 18.68% <ø> (ø)
elasticsearch-8.x-v1 18.85% <ø> (ø)
elasticsearch-8.x-v2 1.66% <ø> (-0.02%) ⬇️
grpc_v1 9.48% <ø> (ø)
grpc_v2 7.00% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.67% <ø> (+0.01%) ⬆️
opensearch-1.x-v1 18.73% <ø> (ø)
opensearch-2.x-v1 18.72% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 1.66% <ø> (-0.02%) ⬇️
tailsampling-processor 0.46% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: chahatsagarmain <[email protected]>
@chahatsagarmain chahatsagarmain changed the title Unit test to reproduce data race when reloading TLF config Unit test to reproduce data race when reloading TLS config Nov 16, 2024
@yurishkuro
Copy link
Member

Have you observe this new test fail? It doesn't look like it's testing race condition deterministically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants