Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cli pr title #83

Merged
merged 38 commits into from
Nov 4, 2024
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
39a7fbc
feat: STRF-11523 Add the ability to use Handlebar Partial Blocks (#1167)
jairo-bc Mar 29, 2024
9ed9f62
chore(release): update release 7.4.0 (#1168)
github-actions[bot] Mar 29, 2024
2f70840
fix: STRF-11898 fix undefined variable stencil scss autofix (#1174)
jairo-bc Apr 4, 2024
718ee9f
chore(release): update release 7.4.1 (#1175)
github-actions[bot] Apr 4, 2024
4376c9e
fix: STRF-11856 - Filter the response for getStoreChannels() to only …
bc-jz Apr 4, 2024
0a0d229
fix: STRF-11856 - Filter list of channels from getStoreChannels() to …
bc-jz Apr 5, 2024
1f1fb9b
chore(release): update release 7.4.2
github-actions[bot] Apr 5, 2024
2da4e51
chore(release): update release 7.4.2
github-actions[bot] Apr 5, 2024
dead9b6
chore(release): update release 7.4.2 (#1182)
bc-jz Apr 8, 2024
ca4221b
feat: STRF-11741 Stencil init: auto install dependencies (#1183)
jairo-bc Apr 9, 2024
2abe41c
chore(release): update release 7.5.0 (#1186)
github-actions[bot] Apr 9, 2024
73703a4
fix: STRF-11923 - Handle missing Channels auth permission in getStore…
bc-jz Apr 10, 2024
20e5fcb
fix: STRF-11923 - Handle Missing a New Channels Permission Requiremen…
bc-jz Apr 10, 2024
2fb7b7d
fix: STRF-11741 Provide stencil init options to set up package manage…
jairo-bc Apr 10, 2024
6840228
chore(release): update release 7.5.1 (#1192)
github-actions[bot] Apr 10, 2024
8790190
chore(release): update release 7.5.2 (#1193)
github-actions[bot] Apr 10, 2024
1560f4e
fix: STRF-11934 Move PR Title to env (#1196)
jairo-bc Apr 15, 2024
e40ba16
chore(release): update release 7.5.3 (#1198)
github-actions[bot] Apr 15, 2024
345f698
fix: STRF-11934 Separate Github PR Title check (#1199)
jairo-bc Apr 16, 2024
cc2bc83
chore(release): update release 7.5.4 (#1200)
github-actions[bot] Apr 16, 2024
13a31ba
fix: STRF-11899 Update cart when multiple coupons are removed (#1197)
huntario Apr 16, 2024
2e0fc02
chore(release): update release 7.5.5 (#1201)
github-actions[bot] Jul 31, 2024
cfbb706
feat: STRF-12315 Bump stencil-paper version; BREAKING CHANGE: Drop No…
jairo-bc Aug 5, 2024
c010a0b
chore(release): update release 8.0.0 (#1218)
github-actions[bot] Aug 5, 2024
72758ef
feat: STRF-11900 Bump paper and handlebars for node 20 (#1219)
jairo-bc Aug 21, 2024
7729f18
chore(release): update release 8.1.0 (#1221)
github-actions[bot] Aug 21, 2024
ac55f21
Show channel IDs in channel prompt when starting dev server (#1222)
loganwoolf Aug 29, 2024
5872c13
Revert "Show channel IDs in channel prompt when starting dev server" …
bc-max Aug 29, 2024
df23a36
feat: Show channel IDs in channel prompt when starting dev server (#1…
bc-max Aug 29, 2024
5f907a3
chore(release): update release 8.2.0 (#1226)
github-actions[bot] Aug 29, 2024
ebd4b05
chore(release): update release 8.1.1 (#1224)
github-actions[bot] Sep 5, 2024
94e97d9
feat: STRF-11834 Consolidate css assembing logic (#1231)
jairo-bc Sep 20, 2024
9e462ea
feat: STRF-11903 Migrate to ESM (#1230)
jairo-bc Sep 24, 2024
ee160f9
chore(release): update release 8.3.0 (#1232)
github-actions[bot] Sep 25, 2024
5ed0cf3
fix: semantic release deploy to npm (#1233)
jairo-bc Sep 26, 2024
250bb07
fix: set node 20 for release (#1234)
jairo-bc Sep 26, 2024
77b96b6
bad commit
jairo-bc Nov 4, 2024
df1e5be
ci
jairo-bc Nov 4, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: STRF-11834 Consolidate css assembing logic (bigcommerce#1231)
jairo-bc authored Sep 20, 2024
commit 94e97d90f0e6bd3a6243a4ba93d6ec3e04437f6b
99 changes: 0 additions & 99 deletions lib/css-assembler.js

This file was deleted.

7 changes: 2 additions & 5 deletions lib/css/compile.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
const path = require('path');
const StencilStyles = require('@bigcommerce/stencil-styles');
const { promisify } = require('util');

const cssAssembler = require('../css-assembler');

const SASS_ENGINE_NAME = 'node-sass';

@@ -11,10 +8,11 @@ const compile = async (configuration, themeAssetsPath, fileName, engineName = SA
const ext = configuration.css_compiler === 'css' ? configuration.css_compiler : 'scss';
const pathToFile = path.join(fileParts.dir, `${fileParts.name}.${ext}`);
const basePath = path.join(themeAssetsPath, `${ext}`);
const stencilStyles = new StencilStyles(console);

let files;
try {
files = await promisify(cssAssembler.assemble)(pathToFile, basePath, `${ext}`, {});
files = await stencilStyles.assembleCssFiles(pathToFile, basePath, `${ext}`, {});
} catch (err) {
console.error(err);
throw err;
@@ -31,7 +29,6 @@ const compile = async (configuration, themeAssetsPath, fileName, engineName = SA
overrideBrowserslist: configuration.autoprefixer_browsers,
},
};
const stencilStyles = new StencilStyles(console);
stencilStyles.activateEngine(engineName);

return stencilStyles.compileCss('scss', params);
9 changes: 5 additions & 4 deletions lib/stencil-bundle.js
Original file line number Diff line number Diff line change
@@ -4,11 +4,11 @@ const async = require('async');
const crypto = require('crypto');
const fs = require('fs');
const path = require('path');
const StencilStyles = require('@bigcommerce/stencil-styles');

const BuildConfigManager = require('./BuildConfigManager');
const BundleValidator = require('./bundle-validator');
const Cycles = require('./Cycles');
const cssAssembler = require('./css-assembler');
const langAssembler = require('./lang-assembler');
const templateAssembler = require('./template-assembler');
const { recursiveReadDir } = require('./utils/fsUtils');
@@ -37,6 +37,8 @@ const PATHS_TO_ZIP = [
{ pattern: 'webpack.*.js' },
];

const stencilStyles = new StencilStyles();

class Bundle {
constructor(
themePath,
@@ -126,13 +128,12 @@ class Bundle {
});
async.map(
filterFiles,
(file, mapCallback) => {
cssAssembler.assemble(
async (file) => {
return stencilStyles.assembleCssFiles(
file,
basePath,
compiler,
assembleOptions,
mapCallback,
);
},
(assemblingError, results) => {
143 changes: 86 additions & 57 deletions package-lock.json
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -49,7 +49,7 @@
],
"dependencies": {
"@bigcommerce/stencil-paper": "5.0.0",
"@bigcommerce/stencil-styles": "5.3.3",
"@bigcommerce/stencil-styles": "^6.1.1",
"@hapi/boom": "^10.0.0",
"@hapi/glue": "^8.0.0",
"@hapi/h2o2": "^9.1.0",