[zh]update agenda/description/speakers #557
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: laliwa <[email protected]>
Signed-off-by: laliwa <[email protected]>
Signed-off-by: laliwa <[email protected]>
Signed-off-by: laliwa <[email protected]>
Signed-off-by: laliwa <[email protected]>
Signed-off-by: laliwa <[email protected]>
Signed-off-by: laliwa <[email protected]>
✅ Deploy Preview for jakartaee-jakartaone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
oliviergoulet5
requested changes
Sep 24, 2024
| <!-- Add speakers section --> | ||
| {{< grid/section-container id="speakers" class="speaker-container text-center">}} | ||
| {{< grid/div class="padding-top-40" isMarkdown="false">}} | ||
| {{< events/user_display year="2024" event="chinese" source="speakers" subpage="speakers" useCarousel="false" imageRoot="/images/speakers/" title="演讲人" headerClass="text-left" />}} |
There was a problem hiding this comment.
I noticed the title parameter is Chinese here, but this is the English _index.md file.
| @@ -0,0 +1,11 @@ | |||
| --- | |||
| title: "Committee Members" | |||
| seo_title: "Jakarta One Livestream - Chinese 2022 | Jakarta EE Software | Cloud Native" | |||
There was a problem hiding this comment.
The seo_title should be corrected to 2024
| @@ -0,0 +1,11 @@ | |||
| --- | |||
| title: "Committee Members" | |||
| seo_title: "Jakarta One Livestream - Chinese 2022 | Jakarta EE Software | Cloud Native" | |||
There was a problem hiding this comment.
The seo_title should be corrected to 2024
| @@ -0,0 +1,11 @@ | |||
| --- | |||
| title: "Speakers" | |||
| seo_title: "JakartaOne Livestream - Chinese | Jakarta EE Software | Cloud Native" | |||
There was a problem hiding this comment.
The seo_title param controls what is placed in the <title> tag.
I suggest we add the year 2024 here. Having multiple pages with identical title tags is bad for SEO.
| @@ -0,0 +1,11 @@ | |||
| --- | |||
| title: "演讲人" | |||
| seo_title: "JakartaOne Livestream - Chinese | Jakarta EE Software | Cloud Native" | |||
There was a problem hiding this comment.
The seo_title here should also be unique.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[zh]update agenda/description/speakers