-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zh]update agenda/description/speakers #557
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: laliwa <[email protected]>
Signed-off-by: laliwa <[email protected]>
Signed-off-by: laliwa <[email protected]>
Signed-off-by: laliwa <[email protected]>
Signed-off-by: laliwa <[email protected]>
Signed-off-by: laliwa <[email protected]>
Signed-off-by: laliwa <[email protected]>
✅ Deploy Preview for jakartaee-jakartaone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch looks good for the most part. I appreciate the pull request!
I suggest we add a few minor edits to help with SEO. Also, one small edit for some remaining Chinese text on an English language page.
<!-- Add speakers section --> | ||
{{< grid/section-container id="speakers" class="speaker-container text-center">}} | ||
{{< grid/div class="padding-top-40" isMarkdown="false">}} | ||
{{< events/user_display year="2024" event="chinese" source="speakers" subpage="speakers" useCarousel="false" imageRoot="/images/speakers/" title="演讲人" headerClass="text-left" />}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the title
parameter is Chinese here, but this is the English _index.md file.
@@ -0,0 +1,11 @@ | |||
--- | |||
title: "Committee Members" | |||
seo_title: "Jakarta One Livestream - Chinese 2022 | Jakarta EE Software | Cloud Native" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The seo_title
should be corrected to 2024
@@ -0,0 +1,11 @@ | |||
--- | |||
title: "Committee Members" | |||
seo_title: "Jakarta One Livestream - Chinese 2022 | Jakarta EE Software | Cloud Native" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The seo_title
should be corrected to 2024
@@ -0,0 +1,11 @@ | |||
--- | |||
title: "Speakers" | |||
seo_title: "JakartaOne Livestream - Chinese | Jakarta EE Software | Cloud Native" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The seo_title
param controls what is placed in the <title>
tag.
I suggest we add the year 2024 here. Having multiple pages with identical title tags is bad for SEO.
@@ -0,0 +1,11 @@ | |||
--- | |||
title: "演讲人" | |||
seo_title: "JakartaOne Livestream - Chinese | Jakarta EE Software | Cloud Native" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The seo_title
here should also be unique.
[zh]update agenda/description/speakers