Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate PersistenceUnitTransactionType #477

Closed
gavinking opened this issue Aug 21, 2023 · 4 comments · Fixed by #486 or #500
Closed

deprecate PersistenceUnitTransactionType #477

gavinking opened this issue Aug 21, 2023 · 4 comments · Fixed by #486 or #500

Comments

@gavinking
Copy link
Contributor

After #465 we have the API PersistenceTransactionType and the SPI PersistenceUnitTransactionType.

We can deprecate PersistenceUnitTransactionType for removal.

@gavinking
Copy link
Contributor Author

@lukasj Two questions:

  1. should we add EntityManagerFactory.getTransactionType()?
  2. should we rename this enum to the overly-verbose-but-more-precise PersistenceTransactionManagementType?

@gavinking
Copy link
Contributor Author

Or just PersistenceTransactionManagement?

@hantsy
Copy link
Contributor

hantsy commented Aug 23, 2023

PersistenceTransactionType is ok, but it seems txType attribute of @Transactional() is not a good naming, will confuse developers. The Spring @Transactional propagation is more reasonable.

@gavinking
Copy link
Contributor Author

@hantsy I agree, I don't like Transactional.TxType at all, neither its name, nor the fact that it's an inner enum of an annotation. I would have liked to be able to reuse it in #410. But for those reasons, and because Lukas doesn't want a direct dependency to the JTA module, we're not going to use it, and we're just going to live with REQUIRED semantics.

gavinking added a commit to gavinking/jpa-api that referenced this issue Aug 23, 2023
gavinking added a commit to gavinking/jpa-api that referenced this issue Aug 23, 2023
gavinking added a commit to gavinking/jpa-api that referenced this issue Aug 23, 2023
@gavinking gavinking linked a pull request Aug 23, 2023 that will close this issue
gavinking added a commit to gavinking/jpa-api that referenced this issue Aug 23, 2023
gavinking added a commit to gavinking/jpa-api that referenced this issue Aug 24, 2023
….getTransactionType

rename PersistenceTransactionType to PersistenceUnitTransactionType

see jakartaee#477
gavinking added a commit to gavinking/jpa-api that referenced this issue Aug 24, 2023
….getTransactionType

rename PersistenceTransactionType to PersistenceUnitTransactionType

see jakartaee#477
lukasj pushed a commit that referenced this issue Aug 24, 2023
….getTransactionType

rename PersistenceTransactionType to PersistenceUnitTransactionType

see #477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants