Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove raw types from APIs and fix typesafety of @Convert annotation #487

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

gavinking
Copy link
Contributor

@gavinking gavinking commented Aug 23, 2023

see #116 and #56

@@ -193,7 +193,7 @@
* element must be specified if multiple converters would
* otherwise apply.
*/
Class converter() default void.class;
Class<? extends AttributeConverter> converter() default AttributeConverter.class;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukasj Note this change.

Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit 40bd531 into jakartaee:master Aug 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@Convert annotation's converter property should be Class<? extends AttributeConverter>, not Class (unsafe)
2 participants