Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typesafe operations for controlling find() queries #415

Closed
wants to merge 4 commits into from

Conversation

gavinking
Copy link
Contributor

See #383.

  • Added the Find interface.
  • Also added a way to set the cache modes for a Query, and the EntityGraph for a TypedQuery.

@gavinking
Copy link
Contributor Author

This proposal is partially superseded by #436.

However, the operations added to Query and TypedQuery are not in #436. And also perhaps the method naming conventions here are better? (setFoo() vs withFoo())

So we should discuss how to proceed with these two competing PRs.

@gavinking gavinking mentioned this pull request Aug 9, 2023
@trajano
Copy link

trajano commented Aug 9, 2023

with... as long as it is fluent

@gavinking
Copy link
Contributor Author

@trajano The argument against that is that we should keep names consistent across Query and Finder. So I'm uncertain which way to go on this.

@trajano
Copy link

trajano commented Aug 10, 2023

I would prefer we mark the non-fluent set methods as deprecated and replace with with if it is fluent. Convention-wise with we expect it to return this whereas set we don't.

@gavinking
Copy link
Contributor Author

@trajano after discussing with @lukasj last night, we have decided to go in a completely different direction.

@gavinking gavinking closed this Aug 11, 2023
@trajano
Copy link

trajano commented Aug 11, 2023

Can you link to the different direction @gavinking

@gavinking
Copy link
Contributor Author

#383 (comment)

#454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants