Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SchemaManager #431

Merged
merged 1 commit into from
Aug 21, 2023
Merged

add SchemaManager #431

merged 1 commit into from
Aug 21, 2023

Conversation

gavinking
Copy link
Contributor

@gavinking gavinking commented Aug 8, 2023

This is a first draft proposal, looking for feedback!

see #399, #68, and #53

@gavinking gavinking mentioned this pull request Aug 8, 2023
@gavinking gavinking force-pushed the schemamanager branch 6 times, most recently from b064af7 to 41185c9 Compare August 10, 2023 20:25
@gavinking gavinking linked an issue Aug 11, 2023 that may be closed by this pull request
@gavinking gavinking force-pushed the schemamanager branch 6 times, most recently from f76f536 to 6d9d407 Compare August 11, 2023 16:35
@gavinking
Copy link
Contributor Author

@lukasj This is ready now, I believe. Please review 🙏

Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit b48e1d4 into jakartaee:master Aug 21, 2023
2 checks passed
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Nov 29, 2023
Initial implementation.

Signed-off-by: Tomáš Kraus <[email protected]>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Dec 5, 2023
Initial implementation.

Signed-off-by: Tomáš Kraus <[email protected]>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Dec 5, 2023
Initial implementation.

Signed-off-by: Tomáš Kraus <[email protected]>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Dec 6, 2023
Fixed MySQL test failures. Added nullable field definition check.

Signed-off-by: Tomáš Kraus <[email protected]>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Dec 7, 2023
Added jakarta.persistence.schema-generation.database.action verify support.

Signed-off-by: Tomáš Kraus <[email protected]>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Dec 7, 2023
fixed test failure.

Signed-off-by: Tomáš Kraus <[email protected]>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Dec 8, 2023
Final code cleanup.

Signed-off-by: Tomáš Kraus <[email protected]>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Dec 13, 2023
Initial implementation.

Signed-off-by: Tomáš Kraus <[email protected]>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Dec 13, 2023
Fixed failing tests with Oracle DB.

Signed-off-by: Tomáš Kraus <[email protected]>
Tomas-Kraus added a commit to Tomas-Kraus/eclipselink that referenced this pull request Dec 15, 2023
lukasj pushed a commit to eclipse-ee4j/eclipselink that referenced this pull request Dec 20, 2023
Initial implementation.

Signed-off-by: Tomáš Kraus <[email protected]>
lukasj pushed a commit to eclipse-ee4j/eclipselink that referenced this pull request Dec 20, 2023
Fixed failing tests with Oracle DB.

Signed-off-by: Tomáš Kraus <[email protected]>
lukasj pushed a commit to eclipse-ee4j/eclipselink that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SchemaManager update and/or validate javax.persistence.schema-generation.database.action
2 participants