-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JPA standalone TCK refactor with Junit. #1202
Conversation
Signed-off-by: Gurunandan Rao <[email protected]>
Signed-off-by: Gurunandan Rao <[email protected]>
Signed-off-by: Gurunandan Rao <[email protected]>
Signed-off-by: Gurunandan Rao <[email protected]>
Signed-off-by: Gurunandan Rao <[email protected]>
Signed-off-by: Gurunandan Rao <[email protected]>
Signed-off-by: Gurunandan Rao <[email protected]>
Signed-off-by: Gurunandan Rao <[email protected]>
Signed-off-by: Gurunandan Rao <[email protected]>
Signed-off-by: Gurunandan Rao <[email protected]>
Signed-off-by: Gurunandan Rao <[email protected]>
Signed-off-by: Gurunandan Rao <[email protected]>
Signed-off-by: Gurunandan Rao <[email protected]>
Signed-off-by: Gurunandan Rao <[email protected]>
Signed-off-by: Gurunandan Rao <[email protected]>
Signed-off-by: Gurunandan Rao <[email protected]>
@gurunrao previously, the Persistence Providers were able to test without a Jakarta EE application server. Testing Persistence Spec implementations with a Jakarta EE application server introduces additional requirements for the implementations. Having said that, I think this pull request is very good progress forward! Since you have already started adding EE testing in this pull request, could we just make this effort handle the @lukasj do you have anything to add? |
@scottmarlow - The refactored standalone JPA TCK is using GF eclipselink libraries[TCK tests does not run inside the GF container]. The refactored TCK runs in same manner with GF, as EE 10 standalone JPA TCK. The scope of PR is for standalone JPA TCK and not for JPA Platform TCK. |
Thanks @gurunrao , I saw EJB beans in the source like jpa/src/main/java/com/sun/ts/tests/jpa/ee/packaging/ejb/descriptor/Stateful3Bean.java which led to me thinking that we were running EE tests inside the GF container but just because the source is there, doesn't make it so. Thanks for pointing this out. |
@gurunrao should we merge and continue work on it via separate pull requests after? |
Please note, The JPA Platform TCK has an overlap of tests with Standalone JPA TCK [ there is an overlap of more than 90% of tests], Hence we need to revisit tests covered as part of |
Signed-off-by: Gurunandan Rao <[email protected]>
44a1299
to
b1869a9
Compare
Signed-off-by: Gurunandan Rao <[email protected]>
b1869a9
to
2c25c9d
Compare
Signed-off-by: Gurunandan Rao <[email protected]>
762d349
to
68fe512
Compare
Signed-off-by: Gurunandan Rao <[email protected]>
@gurunrao How long will it take to merge this PR? I'd like to start working on set of tests to validate Jakarta Persistence 3.2 in near future. |
Please use master branch since PR needs tobe reviewed and merged by the community. We should sync with tckrefactor the changes made againts master branch post merge of the PR. |
Regarding jpa tests that need to work with vehicles for deploying on Platform/profile implementations. I am thinking we need to:
|
The vehicles used by JPA tests for Platform TCK are listed in file vehicle.properties [ https://github.com/jakartaee/platform-tck/blob/master/install/jakartaee/other/vehicle.properties#L105 ]. The vehicles will require a generic implementation, to be used by all the modules. |
@scottmarlow - I am planning to merge the PR[EOD today], since there are no review comments for JPA Standalone Tests refactor. |
Thanks @gurunrao for the change! |
JPA standalone TCK refactor with Junit 5.
Current status of test execution with GF 7 Eclipse Link run are
Tests run: 2071, Failures: 0, Errors: 1, Skipped: 3
Error test name: com.sun.ts.tests.jpa.se.entityManagerFactory.ClientIT#createEntityManagerFactoryNoBeanValidatorTest
PS: PR doesn't include code changes for Signature tests.
TODO: CI jobs for test run with GF 7 and fix for one test error.