Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCK Refactor of JSP & EL Standalone Signature tests #1209

Merged

Conversation

alwin-joseph
Copy link
Contributor

Related Issue(s)
#1126

Describe the change
This converts the signature tests in JSP & EL standalone TCKs to JUnit tests.
Below tests are moved to the respective standalone TCK folders:

  • signaturetest/src/main/java/com/sun/ts/tests/signaturetest/el/ELSigTest.java
  • signaturetest/src/main/java/com/sun/ts/tests/signaturetest/jsp/JSPSigTest.java

The TCK runners are modified to pick up these tests for execution.

There was mention about pending conversion of signature tests in below related PRs:

@gurunrao
Copy link
Contributor

gurunrao commented Dec 19, 2023

IMO, having a maven runner for standalone signature tests should be sufficient. Maven runner will be easy for vendors to understand.
Also since signature tools have ability to ignore the JDK classes, we should be able to remove dependency on jimage tool and respective class dump for signature test run.

@alwin-joseph alwin-joseph marked this pull request as draft January 8, 2024 07:37
@alwin-joseph alwin-joseph marked this pull request as ready for review February 9, 2024 20:39
@alwin-joseph
Copy link
Contributor Author

IMO, having a maven runner for standalone signature tests should be sufficient. Maven runner will be easy for vendors to understand. Also since signature tools have ability to ignore the JDK classes, we should be able to remove dependency on jimage tool and respective class dump for signature test run.

Apparently the maven runner of the sigtest-maven-plugin uses target "check" from https://github.com/eclipse-ee4j/jakartaee-tck-tools/blob/master/tools/sigtest/src/main/java/org/netbeans/apitest/SigtestCheck.java only.

The legacy signature test runner uses https://github.com/jtulach/netbeans-apitest/blob/master/src/main/java/com/sun/tdk/signaturetest/SignatureTest.java which has static and reflective modes of running the signature test.

IMO we can continue to use the legacy way for now until further improvement is made to the sigtest tool to execute src/main/java/com/sun/tdk/signaturetest/SignatureTest via maven. So currently we do use the sigtest-maven-plugin , but the legacy framework is made to call the plugin with appropriate parameters.

@alwin-joseph alwin-joseph merged commit dc05fc9 into jakartaee:tckrefactor Feb 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants