Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call std::process::exit directly from CommandLineArgs. #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andriyDev
Copy link
Contributor

Previously, sending an AppExit event would result in the window opening up (which can be annoying). Now, by just calling std::process:exit, we just quit right on the spot.

Note we already std::process::exit in the help flag, so this isn't much different.

Previously, sending an AppExit event would result in the window opening up (which can be annoying). Now, by just calling std::process:exit, we just quit right on the spot.

Note we already std::process::exit in the help flag.
@jakobhellermann
Copy link
Owner

Hm, I'm trying to remember why I did things this way. I think it had to do with the fact, that only after running the app once, the system information is initialized which would let us display the infos about which components and resources are accessed from a system. But then the graph would have to be rendered after that anyways, not in plugin::finish...

@andriyDev
Copy link
Contributor Author

This seems to be the case in the original CLI PR, authored by another contributor. They might have more context.

Perhaps the intent is to allow other plugins to do their own CLI and then exit? This approach exits immediately. This might be less of an issue now that we're in finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants