Support int64 in arguments

[tomas-novotny]

When consuming stream queue, you send starting numeric offset value as header argument.

$client = new Client();
$channel = $client->channel();

$channel->consume(consumeCallback(...), "stream-queue-name", arguments: [
    'x-stream-offset' => 2_147_958_060,
]);

When offset is larger then limit of int32, it starts returning messages from the beginning of the queue due to offset overflow because now any int is encoded like this:

$buffer->appendUint8(Constants::FIELD_LONG_INT);
$buffer->appendInt32($value);

The simplest solution is to use int64 instead, which works for any int from PHP code, or (as in this PR) at least support int64 with int32 as the default for smaller numbers.

$buffer->appendUint8(Constants::FIELD_LONG_LONG_INT);
$buffer->appendInt64($value);

[tomas-novotny]

If preferred, I can change it to only encode int values as int64. This will make the code cleaner.

[WyriHaximus]

If preferred, I can change it to only encode int values as int64. This will make the code cleaner.

That would make sense tbh. Was going to ask if this impacts #139, and that this obviously requires 64bit PHP. (Which I assume pretty much everyone uses these days.)

[tomas-novotny]

I don't know how this relates to #139...

It doesn't actually require 64-bit PHP, it checks for 64-bit support here and on 32-bit system encodes large numbers in halves here.

So it should not break anything to use

$buffer->appendUint8(Constants::FIELD_LONG_LONG_INT);
$buffer->appendInt64($value);

or (because on 32-bit system you are unable to set larger int number than int32 anyway)

if (PHP_INT_SIZE === 4) {
    $buffer->appendUint8(Constants::FIELD_LONG_INT);
    $buffer->appendInt32($value);
} else {
    $buffer->appendUint8(Constants::FIELD_LONG_LONG_INT);
    $buffer->appendInt64($value);
}

[WyriHaximus]

I don't know how this relates to #139...

Good, wasn't this expecting it to be but wanted to make sure.

It doesn't actually require 64-bit PHP, it checks for 64-bit support here and on 32-bit system encodes large numbers in halves here.

So it should not break anything to use

Fair, and on 32bit systems you can't pass an integer requiring to use appendInt64 over appendInt32 anyway.

if (PHP_INT_SIZE === 4) {
    $buffer->appendUint8(Constants::FIELD_LONG_INT);
    $buffer->appendInt32($value);
} else {
    $buffer->appendUint8(Constants::FIELD_LONG_LONG_INT);
    $buffer->appendInt64($value);
}

This one works for me, just to be slightly more on the safe side.

[WyriHaximus]

Awesome! Thanks for putting the final touches on this PR 👍