Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CanCanCan dependency to allow v2+ #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

grumpit
Copy link

@grumpit grumpit commented Feb 28, 2019

This enables projects that use Canard to update to the latest version of CanCanCan and handles deprecation warnings for Rails 6 that are resolved in v2.x

@james2m
Copy link
Owner

james2m commented Feb 28, 2019

Thanks for the contribution. Happy to merge if you can get the CI passing. I’m traveling right now so won’t get hands to a keyboard for a few days.

@grumpit
Copy link
Author

grumpit commented Feb 28, 2019

So it has to do with the version of SQLite3 that Rails 3.x wants vs. what's available. If I pin sqlite3 to ~> 1.3.5 in Gemfile, I can get tests to run, but with lots of deprecation warnings, a circular reference warning, and errors. I think much of this has to do with the old version of Rails, but I'll have to do more digging later on.

@grumpit
Copy link
Author

grumpit commented Feb 28, 2019

All the errors are around Mongo, which no one should be using anyway ;)
EDIT: this was because I don't have Mongo installed locally, so I pushed the modified version, which ran, and passed on Ruby builds for 2.2 - 2.4. Fails for Ruby < 2.2 and jRuby... (see details here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants