Add second animation curve option for modal bottom sheet #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2024
nivisi
reviewed
Aug 13, 2024
| @@ -68,6 +69,7 @@ class ModalBottomSheet extends StatefulWidget { | |||
| /// | |||
| /// If no curve is provided it falls back to `decelerateEasing`. | |||
| final Curve? animationCurve; | |||
| final Curve? secondAnimationCurve; | |||
There was a problem hiding this comment.
I'd recommend naming it reverseAnimationCurve
Comment on lines
70
to
+72
| /// If no curve is provided it falls back to `decelerateEasing`. | ||
| final Curve? animationCurve; | ||
| final Curve? secondAnimationCurve; |
There was a problem hiding this comment.
We should also provide documentation what it is used for.
| @@ -337,10 +340,12 @@ class ModalBottomSheetState extends State<ModalBottomSheet> | |||
| } | |||
|
|
|||
| Curve get _defaultCurve => widget.animationCurve ?? _decelerateEasing; | |||
| Curve get _defaultSecondCurve => widget.secondAnimationCurve ?? _decelerateEasing; | |||
There was a problem hiding this comment.
Imo should return _defaultCurve.flipped as a fallback
Comment on lines
+376
to
378
| final animationValue = (_dismissUnderway && !isDragging ? secondAnimationCurve : animationCurve).transform( | ||
| widget.animationController.value, | ||
| ); |
There was a problem hiding this comment.
Suggested change
| final animationValue = (_dismissUnderway && !isDragging ? secondAnimationCurve : animationCurve).transform( | |
| widget.animationController.value, | |
| ); | |
| final effectiveCurve = _dismissUnderway && !isDragging | |
| ? secondAnimationCurve | |
| : animationCurve; | |
| final animationValue = effectiveCurve.transform( | |
| widget.animationController.value, | |
| ); |
|
Hi sir @jamesblasco mind taking a look at this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.