Big Update

jameschapman19 · Dec 8, 2023 · eac502a · eac502a
1 parent 94fb509
commit eac502a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cca_zoo/datasets/simulated.py b/cca_zoo/datasets/simulated.py
@@ -295,7 +295,7 @@ def __init__(
             )
         ]
         self.true_loadings = [
-            covariance_factor.T @ (covariance_factor @ weight)
+            covariance_factor @ (covariance_factor.T @ weight)
             for weight, covariance_factor in zip(
                 self.true_features, self.covariance_factors
             )

diff --git a/cca_zoo/linear/_gradient/_objectives.py b/cca_zoo/linear/_gradient/_objectives.py
@@ -16,7 +16,7 @@ def CCA_CV(representations: List[np.ndarray]):
     for i, zi in enumerate(representations):
         V += np.cov(zi.T)  # In-place addition
         for j, zj in enumerate(representations):
-            C += cross_cov(zi, zj)  # In-place addition
+            C += cross_cov(zi, zj, rowvar=False)  # In-place addition
 
     C /= len(representations)  # In-place division
     V /= len(representations)  # In-place division