Improve quality of build.sh

jamesoff · Feb 20, 2017 · 715539f · 715539f
1 parent 9d8dbc9
commit 715539f
Showing 1 changed file with 8 additions and 13 deletions.
diff --git a/build/build.sh b/build/build.sh
@@ -2,30 +2,25 @@
 
 set -eu
 
-VERSION=$1
+VERSION="${1?Missing version parameter}"
 BUILDDIR=simplemonitor-$VERSION
 
-if [ -z "$VERSION" ]; then
-	echo Missing version parameter
-	exit 1
-fi
-
 cd build
 
-[ -d $BUILDDIR ] && rm -rf $BUILDDIR
-mkdir $BUILDDIR
+[ -d "$BUILDDIR" ] && rm -rf "$BUILDDIR"
+mkdir "$BUILDDIR"
 
 echo "--> Copying files"
 
-cp -v ../*.py ../monitor.sql ../LICENCE ../README.md ../CHANGELOG $BUILDDIR
-cp -rv ../Monitors ../Alerters ../Loggers ../html $BUILDDIR
+cp -v ../*.py ../monitor.sql ../LICENCE ../README.md ../CHANGELOG "$BUILDDIR"
+cp -rv ../Monitors ../Alerters ../Loggers ../html "$BUILDDIR"
 
 echo
 echo "--> Tidying up"
-find $BUILDDIR -name *.pyc -delete
+find "$BUILDDIR" -name '*.pyc' -delete
 
 echo
 echo "--> Creating archives"
-tar cjf ${BUILDDIR}.tar.gz $BUILDDIR
-zip -r ${BUILDDIR}.zip $BUILDDIR
+tar cjf "${BUILDDIR}.tar.gz" "$BUILDDIR"
+zip -r "${BUILDDIR}.zip" "$BUILDDIR"