Use Qt::QueuedConnection for language message box to avoid hang on iOS #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to https://bugreports.qt.io/browse/QTBUG-64577 on iOS a Qt::QueuedConnection is necessary. Otherwise, the message box would never show up and hang the app.
pljones
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Due to https://bugreports.qt.io/browse/QTBUG-64577 on iOS a Qt::QueuedConnection is necessary on the message box shown if the language changes. Otherwise, the message box would never show up and changing the language would hang the app.
CHANGELOG: iOS: Fix app hang if the language was changed
Context: Fixes an issue?
Related to: #3406
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for review. Tested on iOS 17 and Debian. Both show the message as expected.
What is missing until this pull request can be merged?
Nothing
Checklist