Fix crash on closing iOS chat dialog #3413
Conversation
| @@ -62,7 +62,7 @@ CChatDlg::CChatDlg ( QWidget* parent ) : CBaseDlg ( parent, Qt::Window ) // use | |||
| pMenu->addMenu ( pEditMenu ); | |||
| #if defined( Q_OS_IOS ) | |||
| QAction* action = pMenu->addAction ( tr ( "&Close" ) ); | |||
| connect ( action, SIGNAL ( triggered() ), this, SLOT ( close() ) ); | |||
There was a problem hiding this comment.
Whilst we're doing this, I would like the two lines changed to match the addActions before and after that both include the action handler.
I'll also ask why this should be hide() for iOS and close() for Android -- I'm going to hazard a guess it should be the same request to Qt on both platforms and that Qt should do the right thing.
I'd even go as far as to suggest that having &Close on the menu bar in the app, regardless of platform, wouldn't necessarily be a bad thing.
There was a problem hiding this comment.
As far as I understand hide() is close() minus deleting the dialog.
Somehow on iOS under Qt6 the dialog already gets deleted and close() may attempt to do it twice.
Potentially it's the same on android with Qt6 - but we don't know for sure yet.
Yes, we could add the close menu entry on all OS - on desktop it seems redundant however.
There was a problem hiding this comment.
I'd argue that UI consistency across platforms isn't "redundant" but makes for a more consistent user experience -- with the benefit of reducing code complexity and maintenance overhead.
There was a problem hiding this comment.
The close entry on desktop OS is redundant since there's a close button in the window manager.
It does not make sense to hide the close button in a menu on mobile OS (at least iOS, where there's no back button).
Using close() would crash due to a null pointer dereference
ann0see
force-pushed
the
iOS/FixCrashChat
branch
from
dd375d9
to
0a5e617
Compare
|
@softins I've pushed a new build with this + the icon PR on TestFlight. |
Short description of changes
Using close() instead of hide() would crash the app as soon as one taps at the screen after closing the chat dialog. Due to a null pointer dereference (?).
I do not understand why the app crashes. Probably it's a qt bug.
https://qtcentre.org/threads/5572-QCoreApplication-postEvent-Unexpected-null-receiver (?)
CHANGELOG: iOS: Fix crash on Qt6 after closing the chat window.
Context: Fixes an issue?
Related to: #3406
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
Ready for review.
What is missing until this pull request can be merged?
Discussion. This is a hot fix...
Checklist