Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cases where no rate limiting is used #62

Merged
merged 5 commits into from
Aug 10, 2024

Conversation

augustd
Copy link
Contributor

@augustd augustd commented Oct 19, 2023

In this case I catch the exception that is thrown and create a rate limit object with significantly high (1 billion) remaining requests. The rest of the code operates normally.

@augustd
Copy link
Contributor Author

augustd commented Oct 19, 2023

Fixes #61

@augustd
Copy link
Contributor Author

augustd commented Oct 20, 2023

A nice addition to this would be to suppress/ignore/auto answer 'yes' to the Do you want to continue? [y/N]: message.

Copy link
Owner

@janeklb janeklb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @augustd - thank you for the contributions (just noticed them now!)

ghsearch/gh_search.py Outdated Show resolved Hide resolved
@janeklb
Copy link
Owner

janeklb commented Aug 3, 2024

@augustd are you able to verify that the changes I've made work for you?

@janeklb janeklb merged commit 244d13b into janeklb:main Aug 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants