Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of instance names in Persistent_env #127

Merged
merged 1 commit into from
Jan 30, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/ocaml/typing/persistent_env.ml
Original file line number Diff line number Diff line change
Expand Up @@ -759,9 +759,6 @@ type 'a sig_reader =
Checks that OCaml source is allowed to refer to this module. *)

let acknowledge_pers_struct penv short_path_comps modname pers_name val_of_pers_sig =
if modname.Global_module.Name.args <> [] then
Misc.fatal_errorf "TODO: Unsupported instance name: %a"
Global_module.Name.print modname;
let {persistent_structures; _} = penv in
let import = pers_name.pn_import in
let global = pers_name.pn_global in
Expand Down
Loading