Wrap all operations into a fiber #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running anything that awaits promises in the main fiber is strongly advised against because it can cause weird unexpected behavior.
WyriHaximus
added a commit
to WyriHaximus/rmq-test
that referenced
this pull request
Feb 10, 2025
As an addition to janlanger#1, by running all messages consumer in a fiber as well the awaits in there don't cause additional weirdness. Optionally consider using https://reactphp.org/promise-timer/#sleep as `await(sleep(1));` to no block anything.
janlanger
pushed a commit
that referenced
this pull request
Feb 11, 2025
As an addition to #1, by running all messages consumer in a fiber as well the awaits in there don't cause additional weirdness. Optionally consider using https://reactphp.org/promise-timer/#sleep as `await(sleep(1));` to no block anything.
|
It still behaves the same :( |
|
Doing a local run myself now/this evening. To get a full sense, and confirms some things from my chat |
Just merged jakubkulhan/bunny#164 that should result in the expected behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running anything that awaits promises in the main fiber is strongly advised against because it can cause weird unexpected behavior.