change internal object name to "backstage-<cr-name>" #356
Conversation
Signed-off-by: gazarenkov <[email protected]>
|
/cc |
There was a problem hiding this comment.
LGTM, but the DB hostname needs to be changed in the following example: https://github.com/janus-idp/operator/blob/main/examples/bs-existing-secret.yaml
Otherwise, the E2E tests are failing, due to the app pod not being able to start (from the logs: ForwardedError: Plugin 'permission' startup failed; caused by Error: Failed to connect to the database to make sure that 'backstage_plugin_permission' exists, Error: getaddrinfo ENOTFOUND bs-existing-secret-backstage-db):
$ make test-e2e IMG=quay.io/janus-idp/operator:0.2.0-pr-356-59f36eb
[...]
Summarizing 1 Failure:
[FAIL] Backstage Operator E2E Examples CRs when applying with custom DB auth secret (examples/bs-existing-secret.yaml) [It] should handle CR as expected
/home/asoro/work/projects/backstage/janus-idp/operator/tests/e2e/e2e_test.go:192
Ran 5 of 5 Specs in 813.293 seconds
FAIL! -- 4 Passed | 1 Failed | 0 Pending | 0 Skipped
--- FAIL: TestE2E (813.29s)
FAIL
Ginkgo ran 1 suite in 13m36.113282877s
Test Suite Failed
make: *** [Makefile:409: test-e2e] Error 1Signed-off-by: gazarenkov <[email protected]>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Swapped managed object names from "-backstage" to "backstage-" to make it compatible with 1.1 OOTB
Fixes #355
Fixes https://issues.redhat.com/browse/RHIDP-2278