Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heregex Comment #5435

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Heregex Comment #5435

wants to merge 5 commits into from

Commits on Nov 26, 2022

  1. Heregex Comment

    Fixes jashkenas#5428
    
    This fix is simple enough but it causes a substantial change in behavior for Heregexes.
    
    `#` inside of a character class shouldn't be considered a comment. By treating `#`
    without whitespace in front as non-comments we could have slight compatability with
    Python.
    
    There are other places in the CoffeeScript source where people avoided escaping the `#`
    by keeping it next to non-whitespace characters even outside of a character class. This
    is different than how Python does it and is probably a bug but maybe it is too late with
    the de facto CoffeeScript2 behavior.
    
    I'm not sure if this should be merged in since it changes the behavior quite a lot. Maybe
    another one for the CoffeeScript3/Civet bucket.
    
    Refs
    ---
    Python Docs: https://docs.python.org/3/library/re.html#re.X
    STRd6 committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    a4b6e8a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f98d8c7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    db69431 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2022

  1. fixed test

    STRd6 committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    9a7054d View commit details
    Browse the repository at this point in the history
  2. doc:test

    STRd6 committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    6b50613 View commit details
    Browse the repository at this point in the history