This repository has been archived by the owner on Jul 23, 2023. It is now read-only.
Settings VC #103
Merged
Settings VC #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
=======================================
Coverage 67.14% 67.14%
=======================================
Files 34 34
Lines 831 831
=======================================
Hits 558 558
Misses 273 273
Continue to review full report at Codecov.
|
|
Preview: http://i.imgur.com/fQFAp11.png |
xiendong
suggested changes
Apr 7, 2017
| } | ||
| } | ||
|
|
||
| private func promptSignIn() -> Bool { |
There was a problem hiding this comment.
what does promptSignIn return? is it shouldPromptSignIn or prompt signed in or prompt displayed success?
| return false | ||
| } | ||
|
|
||
| private func showAlert(title: String, message: String) { |
There was a problem hiding this comment.
Might actually want to abstract this into a helper class in the future.
xiendong
approved these changes
Apr 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #100 for some background info