Code Improvements

jason5ng32 · Feb 1, 2025 · bd9c911 · bd9c911
1 parent 38676ed
commit bd9c911
Show file tree

Hide file tree

Showing 17 changed files with 450 additions and 379 deletions.
diff --git a/frontend/components/Footer.vue b/frontend/components/Footer.vue
@@ -40,26 +40,14 @@
       <div class="offcanvas-body" ref="offcanvasBody">
         <div v-if="showAbout">
           <div class="mb-3">
-            <p>
-              {{ t('about.product1') }}
-            </p>
-            <p>
-              {{ t('about.product2') }}
-            </p>
-            <p>
-              {{ t('about.product3') }}
+            <p v-for="i in 3" :key="i">
+              {{ t(`about.product${i}`) }}
             </p>
           </div>
           <h5>{{ t('about.meTitle') }}</h5>
           <div class="mb-3">
-            <p>
-              {{ t('about.me1') }}
-            </p>
-            <p>
-              {{ t('about.me2') }}
-            </p>
-            <p>
-              {{ t('about.me3') }}
+            <p v-for="i in 3" :key="i">
+              {{ t(`about.me${i}`) }}
             </p>
           </div>
           <div class="mb-3 mx-2">

diff --git a/frontend/components/Nav.vue b/frontend/components/Nav.vue
@@ -92,31 +92,37 @@
                 <span v-else>{{ t('user.Fields.Fetching') }}</span>
               </span>
             </li>
-            <li v-if="isSignedIn">
-              <button type="button" class="dropdown-item" @click="store.setTriggerAchievements(true)"><i
-                  class="bi bi-award-fill"></i> {{t('user.MyAchievements')}} </button>
-            </li>
-            <li v-if="isSignedIn">
-              <hr class="dropdown-divider" />
-            </li>
-            <li v-if="!isSignedIn"><button type="button" class="dropdown-item" @click="store.signInWithGoogle"><i
-                  class="bi bi-google"></i> {{ t('user.SignInWithGoogle') }}</button></li>
-            <li v-if="!isSignedIn"><button type="button" class="dropdown-item" @click="store.signInWithGithub"><i
-                  class="bi bi-github"></i> {{ t('user.SignInWithGithub') }}</button></li>
-            <li v-if="!isSignedIn">
-              <hr class="dropdown-divider" />
-            </li>
+            <template v-if="isSignedIn">
+              <li>
+                <button type="button" class="dropdown-item" @click="store.setTriggerAchievements(true)"><i
+                    class="bi bi-award-fill"></i> {{t('user.MyAchievements')}} </button>
+              </li>
+              <li>
+                <hr class="dropdown-divider" />
+              </li>
+            </template>
+            <template v-if="!isSignedIn">
+              <li><button type="button" class="dropdown-item" @click="store.signInWithGoogle"><i
+                    class="bi bi-google"></i> {{ t('user.SignInWithGoogle') }}</button></li>
+              <li><button type="button" class="dropdown-item" @click="store.signInWithGithub"><i
+                    class="bi bi-github"></i> {{ t('user.SignInWithGithub') }}</button></li>
+              <li>
+                <hr class="dropdown-divider" />
+              </li>
+            </template>
             <li><button type="button" class="dropdown-item" @click="store.setTriggerUserBenefits(true)"><i
                   class="bi bi-person-hearts"></i>
                 {{
                 t('user.Benefits.Title') }}</button></li>
-            <li v-if="isSignedIn">
-              <hr class="dropdown-divider" />
-            </li>
-            <li v-if="isSignedIn"><button type="button" class="dropdown-item" @click="store.signOut"><i
-                  class="bi bi-box-arrow-right"></i> {{ t('user.SignOut')
-                }}</button>
-            </li>
+            <template v-if="isSignedIn">
+              <li>
+                <hr class="dropdown-divider" />
+              </li>
+              <li><button type="button" class="dropdown-item" @click="store.signOut"><i
+                    class="bi bi-box-arrow-right"></i> {{ t('user.SignOut')
+                  }}</button>
+              </li>
+            </template>
           </ul>
         </div>
       </div>