Add support for GraalJS script engine on RegExp checks #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdoeringNew
commented
Jan 18, 2021
| @@ -71,7 +71,7 @@ private static boolean rhinoScript(final Method method, final Object... args) | |||
| { | |||
| return ImmutableList.of( | |||
| new Object[] { "[^]", true }, | |||
| new Object[] { "(?<=foo)bar", false }, | |||
There was a problem hiding this comment.
I had to change this.
With GraalJS this "Positive Lookbehind" is supported and wouldn't have failed as expected.
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of GraalJS has another advantage.
With ECMAScript 2018 more RegExp features have been added. Nashorn and Rhino do not support these changes but GraalJS does.
I haven't add unit tests. The GraalJS dependency is 20MB big and recommends JDK 11. So I just tested it locally.