Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CompileTestModuleOptions consistent with documentation #275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markslater
Copy link

The README section for Fall-back to classpath mode states that using the Kotlin DSL, you can enable classpath mode while running tests with:

tasks {
  compileTestJava {
        extensions.configure(CompileTestModuleOptions::class) {
            compileOnClasspath = true
        }
    }
}

In fact, in version 1.8.15 of the plugin, you have to write isCompileOnClasspath = true. The reason for this is that the accessor needs to be called getCompileOnClasspath() for it to be treated as a property in Kotlin.

Note that this doesn't affect the Groovy DSL, and that TestModuleOptions works as documented for both Kotlin and Groovy.

I've adjusted the tests to demonstrate the problem, implemented a fix, and deprecated the old method.

Let me know if you want to take a different approach, or you'd like anything adjusting.

…and documentation when using Kotlin Script build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant