Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-225 Upgrade versions of redoc and swagger plugins #225

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

mourjo
Copy link
Contributor

@mourjo mourjo commented Aug 2, 2024

Use latest versions of the swagger plugin and redoc plugin.

Fixes vulnerable dependencies from maven:org.webjars:swagger-ui:3.52.5
CVE-2021-46708 6.1 Improper Restriction of Rendered UI Layers or Frames vulnerability with Medium severity found
CVE-2018-25031 4.3 Improper Input Validation vulnerability with Medium severity found

@dzikoysk
Copy link
Member

We're keeping the same versions on purpose, they're introducing breaking changes quite often and these CVEs are usually not really an issue for us. Did you test these 2 new versions? 🤔

@danshinton
Copy link

these CVEs are usually not really an issue for us

Are you sure they are not an issue? I have to write a justification for a security exception on this and it would be nice if there was an official statement from the project that these vulnerabilities do not apply.

@dzikoysk dzikoysk changed the title Upgrade versions of redoc and swagger plugins GH-225 Upgrade versions of redoc and swagger plugins Sep 24, 2024
@dzikoysk
Copy link
Member

dzikoysk commented Sep 24, 2024

It's not the issue, but I've got some time to test it on my own & submit a patch. Let's jump to the latest version for both, Swagger & ReDoc 👌

@dzikoysk dzikoysk merged commit 19c1762 into javalin:main Sep 24, 2024
2 checks passed
@dzikoysk
Copy link
Member

Released as 6.3.1-SNAPSHOT :)

@danshinton
Copy link

Nice! I just tested the Swagger plugin locally. Looks good! Thank you!

@dzikoysk
Copy link
Member

Great! It'll be available in the next stable build alongside new Javalin version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants