Fixed Class.forName for primitive array types #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rimitive and reference array types.
|
Great, this fixes the bug indeed! Is there an issue relating to it? |
cyrille-artho
approved these changes
Jul 18, 2023
|
I'm not aware of any issue relating to this! |
|
@pparizek : This patch looks good to me, can you please take a look also? |
|
I agree with this fix. |
|
Thank you, and please make the same PR against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, in the current implementation
Class.forName("[B")fails with:which should be fixed by this patch. The type resolution is based on that of
INSTANCEOF.execute(here and here).(Incidentally,
Class.forName("[B")does work in unit tests because there exists a class namedBin the unnamed package.)