Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add digits VAE tutorial #59

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Add digits VAE tutorial #59

merged 1 commit into from
Oct 14, 2024

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Oct 11, 2024

This is a followup to the getting started tutorial.

Rendered preview of the tutorial here: https://jax-ai-stack--59.org.readthedocs.build/en/59/digits_vae.html

@jakevdp jakevdp added the documentation Improvements or additions to documentation label Oct 11, 2024
@jakevdp jakevdp self-assigned this Oct 11, 2024
Copy link
Member

@skye skye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do a super careful read but overall this looks AMAZING

docs/digits_vae.md Outdated Show resolved Hide resolved
docs/digits_vae.md Show resolved Hide resolved
docs/digits_vae.md Outdated Show resolved Hide resolved
@jakevdp jakevdp force-pushed the digits-vae branch 2 times, most recently from 2076076 to 59cd016 Compare October 11, 2024 21:33
@8bitmp3
Copy link

8bitmp3 commented Oct 11, 2024

Thank you @jakevdp . Will review in the next round after you merge the PR with @skye .

Copy link
Member

@skye skye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM btw. I didn't approve before because I assumed you were just merge it when you felt it was ready :)

@jakevdp jakevdp merged commit 57acc2c into jax-ml:main Oct 14, 2024
8 checks passed
@jakevdp jakevdp deleted the digits-vae branch October 14, 2024 17:03
@rcrowe-google
Copy link

Is the stack trace under "Debugging NaNs in JAX" supposed to be that long?

@jakevdp
Copy link
Collaborator Author

jakevdp commented Oct 16, 2024

Yes, that's the current stack trace that JAX generates. See Skye's comments above – there are potentially ways we could update JAX and/or flax to address this.

Copy link
Contributor

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice read, I only saw a couple of typos and have a suggestion for a link. Cheers!

docs/digits_vae.md Show resolved Hide resolved
docs/digits_vae.md Show resolved Hide resolved
docs/digits_vae.md Show resolved Hide resolved
docs/digits_vae.md Show resolved Hide resolved
docs/digits_vae.md Show resolved Hide resolved
docs/digits_vae.md Show resolved Hide resolved
@jakevdp jakevdp mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants