-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add digits VAE tutorial #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't do a super careful read but overall this looks AMAZING
2076076
to
59cd016
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM btw. I didn't approve before because I assumed you were just merge it when you felt it was ready :)
Is the stack trace under "Debugging NaNs in JAX" supposed to be that long? |
Yes, that's the current stack trace that JAX generates. See Skye's comments above – there are potentially ways we could update JAX and/or flax to address this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very nice read, I only saw a couple of typos and have a suggestion for a link. Cheers!
This is a followup to the getting started tutorial.
Rendered preview of the tutorial here: https://jax-ai-stack--59.org.readthedocs.build/en/59/digits_vae.html