Added "Porting PyTorch model to JAX" tutorial #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
force-pushed
the
jax-for-pytorch-users-p2
branch
2 times, most recently
from
a6dc454
to
f48fe33
Compare
jakevdp
requested changes
Oct 21, 2024
| - Activations like `nn.ReLU` -> `lambda x: nnx.relu(x)` | ||
| - Pooling layers like `nn.AvgPool2d` -> `lambda x: nnx.avg_pool(x, ...)` | ||
| - `nn.AdaptiveAvgPool2d(1)` -> `lambda x: nnx.avg_pool(x, (x.shape[1], x.shape[2]))`, x is in NHWC format | ||
| - `nn.Flatten()` -> `lambda x: x.reshape(x.shape[0], -1)` |
There was a problem hiding this comment.
maybe use jax.vmap(jnp.ravel) here? Or is that too magic?
There was a problem hiding this comment.
yes, this is too magic.
vfdev-5
force-pushed
the
jax-for-pytorch-users-p2
branch
from
f48fe33
to
dc9f67f
Compare
|
@melissawm @jakevdp thanks for the review, I applied majority of your suggestions to this tutorial |
vfdev-5
force-pushed
the
jax-for-pytorch-users-p2
branch
from
dc9f67f
to
0c0c43e
Compare
|
The errors on ReadtheDocs are about the headings: You might need to change them to be H3 instead. |
vfdev-5
force-pushed
the
jax-for-pytorch-users-p2
branch
from
0c0c43e
to
c1da57c
Compare
jakevdp
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.