Allow explicit casts to any type. #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_563459153
branch
2 times, most recently
from
a9c93c0
to
a6a5ff0
Compare
... as long as `UnderlyingTy` allows such a cast. XLA has some generic code that casts between types such as `std::complex` or `absl::int128` which are not marked as arithmetic types. PiperOrigin-RevId: 563481854
copybara-service
bot
force-pushed
the
test_563459153
branch
from
a6a5ff0
to
2ca30a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow explicit casts to any type.
... as long as
UnderlyingTyallows such a cast.XLA has some generic code that casts between types
such as
std::complexorabsl::int128which are notmarked as arithmetic types.