Skip to content
This repository has been archived by the owner on Jul 30, 2024. It is now read-only.

pytest runs files named test_* #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

tivvit
Copy link

@tivvit tivvit commented Jan 29, 2016

Current implementation is not testing at all 😉
https://travis-ci.org/jaybaird/python-bloomfilter/jobs/89314785

============================= test session starts ==============================
platform linux2 -- Python 2.6.9 -- py-1.4.26 -- pytest-2.6.4
collected 0 items 

@tivvit
Copy link
Author

tivvit commented Jan 29, 2016

after fix:
https://travis-ci.org/jaybaird/python-bloomfilter/jobs/105753930

============================= test session starts ==============================
platform linux3 -- Python 2.6.9, pytest-2.8.5, py-1.4.31, pluggy-0.3.1
rootdir: /home/travis/build/jaybaird/python-bloomfilter, inifile: 
collected 7 items 
pybloom/test_pybloom.py .......
================= 7 passed, 1 pytest-warnings in 1.09 seconds ==================

@joseph-fox
Copy link

You need to change the (test) file name on https://github.com/joseph-fox/python-bloomfilter/blob/master/tox.ini#L5 too.

@tivvit
Copy link
Author

tivvit commented Feb 10, 2016

fixed, thanks for noticing

@joseph-fox
Copy link

I made a PR months ago, and there has never been a reply or a comment. I am wondering if you are happy to make a PR against my master, so we can continue maintaining this project.

@tivvit
Copy link
Author

tivvit commented Feb 11, 2016

I have no problem with that, but I would like to ask if you have any idea how to get your fork to pip?

@joseph-fox
Copy link

The submission of pypi isn't complicated. I will register an account and look at setup.py, setup.cfg in the next few days.

@tivvit
Copy link
Author

tivvit commented Feb 13, 2016

I have published some packages to pip, but I am afraid that we will have to publish our version under different name.

@joseph-fox
Copy link

Sure. 💯 no problem.

@joseph-fox
Copy link

It is on Pypi now.
https://pypi.python.org/pypi/pybloom_live

richard-rogers pushed a commit to whylabs/whylogs-bloom that referenced this pull request Nov 16, 2023
Adding an import with the regex module
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants