Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe Webhooks #358

Merged
merged 24 commits into from
Jul 19, 2023
Merged

Stripe Webhooks #358

merged 24 commits into from
Jul 19, 2023

Conversation

mariofix
Copy link
Member

  • Webhooks support for stripe.StripeProviderV3
  • internal file order

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #358 (b4b8a91) into main (8737608) will decrease coverage by 0.32%.
The diff coverage is 73.38%.

@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
- Coverage   79.30%   78.99%   -0.32%     
==========================================
  Files          28       29       +1     
  Lines        1899     1947      +48     
  Branches      235      241       +6     
==========================================
+ Hits         1506     1538      +32     
- Misses        276      293      +17     
+ Partials      117      116       -1     
Impacted Files Coverage Δ
payments/stripe/forms.py 93.58% <ø> (-0.17%) ⬇️
payments/stripe/providers.py 72.99% <72.99%> (ø)
payments/stripe/__init__.py 67.30% <100.00%> (-5.36%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mariofix mariofix marked this pull request as ready for review July 4, 2023 03:00
@mariofix mariofix requested a review from WhyNotHugo July 4, 2023 03:00
docs/backends.rst Outdated Show resolved Hide resolved
docs/backends.rst Show resolved Hide resolved
docs/backends.rst Outdated Show resolved Hide resolved
docs/backends.rst Outdated Show resolved Hide resolved
@mariofix mariofix requested a review from WhyNotHugo July 10, 2023 20:22
Copy link
Member

@WhyNotHugo WhyNotHugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures seem unrelated

docs/backends.rst Outdated Show resolved Hide resolved
docs/backends.rst Outdated Show resolved Hide resolved
payments/stripe/__init__.py Outdated Show resolved Hide resolved
@mariofix
Copy link
Member Author

CI failures seem unrelated

yeah, I though they were because of the dj22 drop, need help with these errors?

@WhyNotHugo
Copy link
Member

yeah, I though they were because of the dj22 drop, need help with these errors?

Yeah, I haven't had a chance to look at them, but can reproduce them with tox -e dj42. CI doesn't use pinned dependencies, so I suspect that something got update and is causing the breakage.

@WhyNotHugo WhyNotHugo merged commit d3bd34a into jazzband:main Jul 19, 2023
25 of 27 checks passed
@WhyNotHugo
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants