-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing username to redis arguments #657
base: master
Are you sure you want to change the base?
Passing username to redis arguments #657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution! it would be nice to have a test for this and a change log file
The login for the user ``django`` would look like this: | ||
|
||
.. code-block:: python | ||
|
||
CACHES = { | ||
"default": { | ||
"BACKEND": "django_redis.cache.RedisCache", | ||
"LOCATION": "redis://django@localhost:6379/0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep both examples if they work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged the example in which the username is passed in the URL and the password in the OPTIONS with the example of a URL unsafe password, because I thought it was redundant. Tell me if it suits you as done in 039432c
I added the changelog and a test. I wasn't sure where to test the connection params so I renamed the |
ping ;) |
I would love to have tests to connect to a server with credentials |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #657 +/- ##
========================================
- Coverage 57.5% 56.3% -1.1%
========================================
Files 39 39
Lines 2528 2546 +18
Branches 75 74 -1
========================================
- Hits 1452 1432 -20
- Misses 1059 1097 +38
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
resolves #656