Allowing BigIntegerField in taggedItems #693
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
suggested changes
Oct 15, 2020
| @@ -157,7 +157,7 @@ def tags_for(cls, model, instance=None, **extra_filters): | |||
|
|
|||
|
|
|||
| class GenericTaggedItemBase(CommonGenericTaggedItemBase): | |||
| object_id = models.IntegerField(verbose_name=_("object ID"), db_index=True) | |||
| object_id = models.BigIntegerField(verbose_name=_("object ID"), db_index=True) | |||
There was a problem hiding this comment.
this will break backward compatibility
There was a problem hiding this comment.
I see no other way to fix this issue : (
There was a problem hiding this comment.
They could do a version check of Django before migrating.
And use:
In [1]: import django
In [2]: django.VERSION
Out [2]: (3, 1, 1, 'final', 0)There was a problem hiding this comment.
probably moving to abstract base model is the best futuristic approach
|
This change as-is would break backwards compatibility with everyone using this base. After triaging a hundred+ issues, I think a big thing is the custom tag documentation. I'm going to work on improving it so that there could be a good answer here. But this as-is won't work, unfortunately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows Taggable Items to have BigIntegerField as primary key. See #692