feat: scripts can now implement integrations #1634
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the class loader would not be set up correctly because it expects to be running from an uber JAR with all the dependencies available. Now we specifically add the path to the Gson library in those cases. The user won't notice but it makes life easier for developers.
Before this change JBang would only look for integrations in the dependencies, now it also looks in the currently compiled code.
|
So the discussion to merge this or not was about the issue that user files are now part of the class path when running the post build and if this could result in problems or not. Right now it only runs with all the dependencies specified by the user code, but not the code itself. (Which is why currently it isn't possible to write integration code within the user code). A possible issue might be that the classloader would hold a lock on the very resources that the integration might try to change, something that especially on Windows might cause problems. |
|
with #1641 this should be doable without "polluting" the integration class path. But it does not yet work because the integration assumes all deps have a GAV... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #1630 to be applied first