-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: we can now create junctions on Windows #1804
Conversation
Updated PR with simplified code using The |
dd329c3
to
f95ade4
Compare
On Windows it was possible to leave a JDK in a broken state by changing the default JDK
Checking for Developer Mode when it's only necessary for the `edit` command will only bother users, best to only give the warning when actually needed
@quintesse @maxandersen thoughts on merging this? |
@quintesse didnt we have some concern with this ? I can definitely give it a go again but feel like there was still a higher permission level needed still or was that fixed? |
@maxandersen no, on Windows it will use an external command (that should exist on all modern Windows versions) that needs no extra privileges to create a junction when dealing with links to folders. Only when we use links to files (as for the |
Fixes #1793