Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #117

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mk2510
Copy link
Collaborator

@mk2510 mk2510 commented Jul 22, 2020

  • corrected some spelling mistakes

  • added tokenize to the demo code snippets

  • explanation of which functions take tokenized input

It will still remain as a draft after everything else in #107 is done 🚀

* corrected some spelling mistakes

* added tokenize to the demo code snippeds

*explanation of which functions take tokenize input

Co-authored-by: Henri Froese <[email protected],>
@jbesomi
Copy link
Owner

jbesomi commented Jul 24, 2020

Hey! Top!

For the first two examples, I'm not sure we want to keep the >>>. That way, a user can just copy-paste the code in a jupyter notebook and see the result, without the need to replacing >>>. At least that was my initial consideration, ideas?

For the example 3 (Simple pipeline for text cleaning) it makes sense to keep the >>> as here we show a CLI interaction

@mk2510
Copy link
Collaborator Author

mk2510 commented Jul 24, 2020

ok 🧀 , I will change it back. Just thought it will give it a more uniform look 🐤

cheers :)

@jbesomi
Copy link
Owner

jbesomi commented Jul 24, 2020

Actually, you were right!! thx

@mk2510 mk2510 marked this pull request as ready for review July 24, 2020 14:12
@jbesomi
Copy link
Owner

jbesomi commented Jul 27, 2020

Hi, there are still the >>> ...

removed the >>> where no output was shown



Co-authored-by: Henri Froese <[email protected]>
@mk2510
Copy link
Collaborator Author

mk2510 commented Jul 27, 2020

oh, sorry, I got you wrong there 🙊 I thought with:

Actually, you were right!! thx

you meant, that's alright that way.
I removed it in the first two examples but kept it elsewhere, to better distinguish the code from the output

@mk2510 mk2510 changed the title Update README.md Reviewed and waiting for Representation Implementation: Update README.md Jul 27, 2020
@jbesomi jbesomi marked this pull request as draft July 27, 2020 17:12
@henrifroese henrifroese added the documentation Improvements or additions to documentation label Aug 7, 2020
@mk2510
Copy link
Collaborator Author

mk2510 commented Aug 8, 2020

@jbesomi also waiting here for the PR #135 to be merged, so the link for the Series types tutorial can be included 🏎️

@henrifroese henrifroese changed the title Reviewed and waiting for Representation Implementation: Update README.md Update README.md Aug 22, 2020
@mk2510 mk2510 marked this pull request as ready for review September 5, 2020 16:16
README.md Show resolved Hide resolved

Texthero has been developed for the whole NLP community. We know how hard it is to deal with different NLP tools (NLTK, SpaCy, Gensim, TextBlob, Sklearn): that's why we developed Texthero, to simplify things.

Now, the next main milestone is to provide *multilingual support* and for this big step, we need the help of all of you. ¿Hablas español? Sie sprechen Deutsch? 你会说中文 日本語が話せるのか? Fala português? Parli Italiano? Вы говорите по-русски? If yes or you speak another language not mentioned here, then you might help us develop multilingual support! Even if you haven't contributed before or you just started with NLP, contact us or open a Github issue, there is always a first time :) We promise you will learn a lot, and, ... who knows? It might help you find your new job as an NLP-developer!
Now, the next main milestone is to provide *multilingual support* and for this big step, we need the help of all of you. ¿Hablas español? Sprechen Sie Deutsch? 你会说中文 日本語が話せるのか?Fala português? Parli Italiano? Вы говорите по-русски? If yes or you speak another language not mentioned here, then you might help us develop multilingual support! Even if you haven't contributed before or you just started with NLP, contact us or open a Github issue, there is always a first time :) We promise you will learn a lot, and, ... who knows? It might help you find your new job as an NLP-developer!

For improving the python toolkit and provide an even better experience, your aid and feedback are crucial. If you have any problem or suggestion please open a Github [issue](https://github.com/jbesomi/texthero/issues), we will be glad to support you and help you.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the "Beta version" part still make sense (@jbesomi )?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants