Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in pagination component options story #1143

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

yunghog
Copy link
Contributor

@yunghog yunghog commented Mar 7, 2023

Fix typo in pagination component options story, rowsPerPageText prop description.

  • Before fixing
    image

  • After fixing
    image

Fix typo in pagination option story, rowsPerPageText prop description.
@netlify
Copy link

netlify bot commented Mar 7, 2023

Deploy Preview for react-data-table-component ready!

Name Link
🔨 Latest commit be2106b
🔍 Latest deploy log https://app.netlify.com/sites/react-data-table-component/deploys/640775edb7d2550008c5332a
😎 Deploy Preview https://deploy-preview-1143--react-data-table-component.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yunghog yunghog changed the title Fix typo in pagination option story Fix typo in pagination component options story Mar 7, 2023
@alexk400
Copy link

alexk400 commented Mar 11, 2023

Can someone add this feature. I wanted to have externalise style data
....
var newdest=destination[key];
if(typeof newdest === 'function')
destination[key]=newdest();

color: (opacity=.5) => rgba(255, 255, 255, ${opacity})
this allow all kinda logic added to Table Style object.
Any object properties can be function. if it see a function , it calculate and saved the results.
Let me know if anyone can do this.

i tested with react-data-table-component-dev.js ( index.cjs.js obfuscated)

This is the change

function mergeObject(target, source, options) {
var destination = {};
if (options.isMergeableObject(target)) {
getKeys(target).forEach(function(key) {
destination[key] = cloneUnlessOtherwiseSpecified(target[key], options);
});
}
getKeys(source).forEach(function(key) {
if (propertyIsUnsafe(target, key)) {
return
}

if (propertyIsOnObject(target, key) && options.isMergeableObject(source[key])) {
		destination[key] = getMergeFunction(key, options)(target[key], source[key], options);
	} else {
		destination[key] = cloneUnlessOtherwiseSpecified(source[key], options);
	}

    var newdest=destination[key];
    if(typeof newdest === 'function') 
    {
        //convert anonymous function to result string
        destination[key]=newdest();
    }

});
return destination

}

@alexk400
Copy link

I have another issue and i want to add Plus button. But its render twice. I want it to render along with table. How do i make it render. Why not datatable allow user to have some custom control there?
I have many plans in that corner. Server scrollable control checkbox for checkbox screens , al expand and others.
add button draw issue.webm

@sadashivm
Copy link

Hello @yunghog , how to create a new issue?
I'm unable to see "create issue" button anywhere.
Hence I've added my issue inside below link,

#1140

Please check the above URL.

Can you please tell me how to create a new issue here?

@sadashivm
Copy link

One more issue which is added here,
#1037

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 18, 2023
@jbetancur jbetancur merged commit 06621fa into jbetancur:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants