-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 0xc000007f to mapping #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Microsoft NTSTATUS page lists this error code as STATUS_DISK_FULL
https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-erref/596a1078-e883-4972-9bbc-49e60bebca55. I would probably prefer to keep these values aligned if possible sorry.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #245 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 24 24
Lines 5093 5097 +4
=======================================
+ Hits 5045 5049 +4
Misses 48 48
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Makes sense - thanks! |
Thanks for adding this and appreciate you taking the time to make the changes after my review! |
No problem! I'm actually contributing this as I'm using pypsexec for some automation, so I'd be keen to get this into a release that's on pypi so I can bump the dependency in my application if possible, please? |
Hey @jborean93 - are you able to review the above please? |
Sorry I will look at pushing a new release tomorrow. |
v1.12.0 has been pushed to PyPI with these changes https://pypi.org/project/smbprotocol/. |
Thanks! |
Adds the low disk space code to the mapping, so a more descriptive error is raised.
From https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-cifs/8f11e0f3-d545-46cc-97e6-f00569e3e1bc: