Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 0xc000007f to mapping #245

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Conversation

rsdoherty
Copy link
Contributor

@rsdoherty rsdoherty commented Nov 1, 2023

Adds the low disk space code to the mapping, so a more descriptive error is raised.

From https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-cifs/8f11e0f3-d545-46cc-97e6-f00569e3e1bc:

image

Copy link
Owner

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Microsoft NTSTATUS page lists this error code as STATUS_DISK_FULL https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-erref/596a1078-e883-4972-9bbc-49e60bebca55. I would probably prefer to keep these values aligned if possible sorry.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (942b005) 99.05% compared to head (35f6b8f) 99.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files          24       24           
  Lines        5093     5097    +4     
=======================================
+ Hits         5045     5049    +4     
  Misses         48       48           
Flag Coverage Δ
99.05% <100.00%> (+<0.01%) ⬆️
py3.10 99.01% <100.00%> (+<0.01%) ⬆️
py3.11 99.01% <100.00%> (+<0.01%) ⬆️
py3.12.0-rc.1 99.01% <100.00%> (+<0.01%) ⬆️
py3.7 99.00% <100.00%> (+<0.01%) ⬆️
py3.8 99.01% <100.00%> (+<0.01%) ⬆️
py3.9 99.05% <100.00%> (+<0.01%) ⬆️
x64 99.05% <100.00%> (+<0.01%) ⬆️
x86 98.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/smbprotocol/exceptions.py 100.00% <100.00%> (ø)
src/smbprotocol/header.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rsdoherty
Copy link
Contributor Author

Makes sense - thanks!

@jborean93
Copy link
Owner

Thanks for adding this and appreciate you taking the time to make the changes after my review!

@jborean93 jborean93 merged commit e99ee98 into jborean93:master Nov 1, 2023
29 checks passed
@rsdoherty
Copy link
Contributor Author

No problem! I'm actually contributing this as I'm using pypsexec for some automation, so I'd be keen to get this into a release that's on pypi so I can bump the dependency in my application if possible, please?

@rsdoherty rsdoherty deleted the add-low-disk-space branch November 1, 2023 23:07
@rsdoherty
Copy link
Contributor Author

Hey @jborean93 - are you able to review the above please?

@jborean93
Copy link
Owner

Sorry I will look at pushing a new release tomorrow.

@jborean93
Copy link
Owner

v1.12.0 has been pushed to PyPI with these changes https://pypi.org/project/smbprotocol/.

@rsdoherty
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants