Skip to content

Commit

Permalink
add back commitCheck
Browse files Browse the repository at this point in the history
  • Loading branch information
jbwheatley committed Nov 11, 2024
1 parent 4bd05a0 commit 1ad8fbf
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 30 deletions.
7 changes: 2 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -549,11 +549,8 @@ the following checklist:
- Broken or invalidated methods/fields have had a deprecation tag applied.
- Tests for your new feature or bugfix have been included.
- You've run `sbt scalafmtAll` to format your new code and run `sbt headerCreateAll` to add headers to new files.
- You've run `sbt commitCheck` to check formatting, headers, and run all the test suites.
- Feature parity between the various library implementations is maintained.

*N.B.* `sbt commitCheck` takes a while to run because we need to run each test suite in serial as there is networking involved.
You can save some time locally by using `sbt quickCommitCheck` which doesn't do any cross-building for different scala versions.
- You've run `sbt commitCheck` to check formatting, headers, and run all the test suites across all scala versions.
- Feature parity between the various library implementations is maintained.

---

Expand Down
39 changes: 15 additions & 24 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -261,29 +261,20 @@ addCommandAlias(
)

addCommandAlias(
"quickCommitCheck",
List(
"clean",
"scalafmtCheck",
"headerCheck",
"compile:doc",
"test:compile",
"deletePactFiles",
"project munit",
"test",
"project weaver",
"test",
"project zioTest",
"test",
"project scalaTest",
"test",
"project circe",
"test",
"project playJson",
"test",
"project sprayJson",
"test",
"project /"
)
"commitCheck",
(List("clean", "deletePactFiles", "scalafmtCheck", "headerCheck", "+compile:doc", "+test:compile") ++
List(
"models",
"munit",
"scalaTest",
"weaver",
"zioTest",
"shared",
"circe",
"playJson",
"sprayJson",
"exampleConsumer",
"exampleProvider"
).flatMap(p => List(s"project $p", "+test")))
.mkString(";", ";", "")
)
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ class ReproducerSuite extends AnyFlatSpec with PactVerifier with BeforeAndAfterA
providerName = "Pact4sMessageProvider",
fileName = "./scripts/Pact4sMessageConsumer-Pact4sMessageProvider.json",
verificationSettings =
Some(AnnotatedMethodVerificationSettings(packagesToScan = List("pact4s.scalatest.message.issue19")))
Some(AnnotatedMethodVerificationSettings(packagesToScan = List("pact4s.scalatest.message.issue19"))),
isHttpPact = false
)

@PactVerifyProvider("A message to say goodbye")
Expand Down

0 comments on commit 1ad8fbf

Please sign in to comment.