Add eslint-plugin-n

.eslintrc

@@ -1,5 +1,5 @@
 {
-  "extends": ["jc"],
+  "extends": ["jc", "jc/typescript-typecheck", "jc/node"],
   "parserOptions": {
     "project": true
   },

package.json

@@ -22,6 +22,7 @@
     "eslint-plugin-header": "^3.1.1",
     "eslint-plugin-import": "^2.29.0",
     "eslint-plugin-jsx-a11y": "^6.8.0",
+    "eslint-plugin-n": "^16.3.1",
     "eslint-plugin-react": "^7.33.2",
     "eslint-plugin-react-hooks": "^4.6.0",
     "eslint-plugin-regexp": "^2.1.1",

packages/create-jc-project/src/index.ts

@@ -17,34 +17,47 @@ if (process.argv.includes("--version") || process.argv.includes("-v")) {
 }
 
 console.log(pico.cyan("Starting to scaffold new JC project..."));
-const { name, description, usingReact } = await prompts(
-  [
-    {
-      type: "text",
-      name: "name",
-      message: "What should we call this project?",
-      async validate(value) {
-        if (
-          typeof value !== "string" ||
-          !/^(?:@[a-z-]+\/)?[a-z-]+$/u.test(value)
-        )
-          return "Not a valid package name.";
-        if (await pathExists(value)) return "The directory already exists.";
-        return true;
+function parseValidRes(r: { [key: string]: unknown }) {
+  if (
+    typeof r.name !== "string" ||
+    typeof r.description !== "string" ||
+    typeof r.usingReact !== "boolean"
+  ) {
+    console.log(pico.red("Invalid input."));
+    process.exit(1);
+  }
+  return r as { name: string; description: string; usingReact: boolean };
+}
+const { name, description, usingReact } = parseValidRes(
+  await prompts(
+    [
+      {
+        type: "text",
+        name: "name",
+        message: "What should we call this project?",
+        async validate(value) {
+          if (
+            typeof value !== "string" ||
+            !/^(?:@[a-z-]+\/)?[a-z-]+$/u.test(value)
+          )
+            return "Not a valid package name.";
+          if (await pathExists(value)) return "The directory already exists.";
+          return true;
+        },
+      },
+      {
+        type: "text",
+        name: "description",
+        message: "Brief description?",
       },
-    },
-    {
-      type: "text",
-      name: "description",
-      message: "Brief description?",
-    },
-    {
-      type: "confirm",
-      name: "usingReact",
-      message: "Using React?",
-    },
-  ],
-  { onCancel: () => process.exit(0) },
+      {
+        type: "confirm",
+        name: "usingReact",
+        message: "Using React?",
+      },
+    ],
+    { onCancel: () => process.exit(0) },
+  ),
 );
 const packageJSON = {
   name,
@@ -76,10 +89,10 @@ async function rReadDir(dir: string): Promise<[string, Buffer][]> {
   const dirents = await fs.readdir(dir, { withFileTypes: true });
   const files = await Promise.all(
     dirents.map(async (dirent) => {
-      const res = path.join(dir, dirent.name);
+      const subDir = path.join(dir, dirent.name);
       return dirent.isDirectory()
-        ? rReadDir(res)
-        : [[res, await fs.readFile(res)] as [string, Buffer]];
+        ? rReadDir(subDir)
+        : [[subDir, await fs.readFile(subDir)] as [string, Buffer]];
     }),
   );
   return files.flat();

packages/create-jc-project/src/utils.ts

@@ -17,7 +17,9 @@ export function exec(
       if (((e): e is SpawnSyncReturns<string> => true)(err)) {
         if (err.stdout) console.log(err.stdout);
         if (err.stderr) console.log(err.stderr);
-        console.log(pico.red(`Command exited with code ${err.status}.`));
+        console.log(
+          pico.red(`Command exited with code ${err.status ?? "unknown"}.`),
+        );
         if (index < times - 1) console.log(pico.cyan("Retrying..."));
       }
       return false;

packages/eslint-config/index.js

@@ -7,9 +7,11 @@ module.exports = {
     "./rules/typescript.js",
     "./rules/import.js",
     "./rules/react.js",
-    // Not included by default
+    "./rules/jsx.js",
+    // Not included by default:
+    // "./rules/typescript-typecheck.js",
+    // "./rules/node.js",
     // "./rules/react-class-comps.js",
     // "./rules/react-prop-types.js",
-    "./rules/jsx.js",
   ],
 };

packages/eslint-config/package.json

@@ -27,6 +27,7 @@
     "./base": "./rules/base.js",
     "./regex": "./rules/regex.js",
     "./import": "./rules/import.js",
+    "./node": "./rules/node.js",
     "./jsx": "./rules/jsx.js",
     "./react": "./rules/react.js",
     "./react-class-comps": "./rules/react-class-comps.js",

packages/eslint-config/rules/node.js

@@ -0,0 +1,84 @@
+module.exports = {
+  plugins: ["n"],
+  rules: {
+    // Callback-related
+    "n/callback-return": "off",
+
+    "n/exports-style": ["error", "module.exports", { allowBatchAssign: false }],
+
+    // Checked by TypeScript
+    "n/file-extension-in-import": "off",
+
+    // On-demand loading is useful
+    "n/global-require": "off",
+
+    // Callback-related
+    "n/handle-callback-err": "off",
+
+    // Callback-related
+    "n/no-callback-literal": "off",
+
+    "n/no-deprecated-api": "error",
+
+    "n/no-exports-assign": "error",
+
+    // Shadowed by import/no-extraneous-dependencies
+    "n/no-extraneous-import": "off",
+
+    // Shadowed by import/no-extraneous-dependencies
+    "n/no-extraneous-require": "off",
+
+    // Checked by TypeScript
+    "n/no-missing-import": "off",
+
+    // Checked by TypeScript
+    "n/no-missing-require": "off",
+
+    // Not helpful
+    "n/no-mixed-requires": "off",
+
+    "n/no-new-require": "error",
+
+    "n/no-path-concat": "warn",
+
+    "n/no-process-env": "off",
+
+    // Useful in theory, but too noisy
+    "n/no-process-exit": "off",
+
+    "n/no-restricted-import": "off",
+
+    "n/no-restricted-require": "off",
+
+    "n/no-sync": ["warn", { allowAtRootLevel: false }],
+
+    "n/no-unpublished-bin": "error",
+
+    "n/no-unpublished-import": "off",
+
+    "n/no-unpublished-require": "off",
+
+    "n/prefer-global/buffer": ["error", "always"],
+
+    "n/prefer-global/console": ["error", "always"],
+
+    "n/prefer-global/process": ["error", "always"],
+
+    "n/prefer-global/text-decoder": ["error", "always"],
+
+    "n/prefer-global/text-encoder": ["error", "always"],
+
+    "n/prefer-global/url": ["error", "always"],
+
+    "n/prefer-global/url-search-params": ["error", "always"],
+
+    "n/prefer-promises/dns": "error",
+
+    "n/prefer-promises/fs": "error",
+
+    "n/process-exit-as-throw": "warn",
+
+    // Errors on TypeScript bin
+    "n/shebang": "off",
+  },
+};