Cci revoke #2
Open
Cci revoke #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `create-react-app` boilerplate
remove git submodule, add logging
File restructure
`--frozen` added to Dockerfile
Revert "File restructure"
Revert "add unset triage reminders"
…-specified node version specified
…-need-to-exist remove references to DB dockerfile
SetTriageDuration uses an inplace SQL query to set the duration by calculating the interval of time since the triage started. SetTriageDuraiton is called by removeTriage, which appears to be called every time the active triager changes, whether that's by calling `unset` or by a new triager coming in.
…column SetTriageDuration added
Was trying to set duration of triage on a slice index after it was spliced out. Moved it around so that it is now adding before the splice.
…return-in-post-config Update config.go
Traefik is being deprecated and services are moving to api-gateway. This is also an opportunity to consolidate the sub-domains that are use, by moving similar functioning services onto shared sub-domains, so that: - there's a lower barrier for entry for new services - common features can be applied to related services - it's easier to see how external traffic gets routed to us There are 3 ITD services that look like webhooks because they only receive inbound data. So they can move to `webhook.circleci.com`: - https://circleci.atlassian.net/wiki/spaces/ITD/pages/6329565803/API+Gateway#Available-Subdomains CCC enables `stripPath` by default so the prefix path will be removed from the request that makes it to the service. I've removed "hook" from any paths names, when copying them from the previous sub-domains, because it's now implied by the new sub-domain. Once this is merged then we can: - test the new route in parallel - migrate clients over to the new route - remove the old route - remove DNS
[API-268] values: Add new route for webhooks.circleci.com
This has been using Kong for a while, so this Traefik reference is no longer required.
Remove old Traefik references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is now, CCI is trigger on merge and that means that CCC runs, deploying this outdated version of Deskmate. We need to prevent that, which was done by changing the name of the directory from
.circlecito.circleci-archived