Non standard account name #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2024 19:47
jcornaz
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Awesome, thanks for the PR! Sorry for the inconvenience of the build failure. I fixed the problem in main. If you rebase the CI should pass.
Would you mind adding an explicit test for account name parsing? It's a matter of adding a case to the account_from_str_should_parse_valid_account test in tests/parser_spec.rs.
jcornaz
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
this PR should fix #75
just verifyran successfully.Let me know if you want something changed. I'm still quite new to Rust and nom so I'm happy about any feedback 🙂